Make dashboard honest across real-world states - #160
Open
FZ2000 wants to merge 7 commits into
Open
Conversation
…' into codex/dashboard-real-world-honesty
…' into codex/dashboard-real-world-honesty # Conflicts: # apps/agentacct/Sources/agentacct/DashboardPane.swift # apps/agentacct/Sources/agentacct/DashboardStore.swift # apps/agentacct/Sources/agentacct/V1Model.swift # apps/agentacct/Sources/agentacct/WorkPane.swift # apps/agentacct/Tests/agentacctTests/DashboardInteractionTests.swift # apps/agentacct/Tests/agentacctTests/ReferenceImages/macos-26.6-25G72-xcode-26.6-17F113-arm64-2x/work-list-error-reference-dark.png # apps/agentacct/Tests/agentacctTests/ReferenceImages/macos-26.6-25G72-xcode-26.6-17F113-arm64-2x/work-list-error-reference-light.png # src/agentacct/api.py # tests/test_receipt_api.py
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect in one sentence
Makes Dashboard and Work fail closed across real daemon, legacy, partial, malformed, paged, loading, error, and extreme-number states without inventing guidance or losing the next recorded review item.
Stack position
5 of 6: #153 → #155 → #157 → #159 → #160 (this hardening layer) → #161.
This branch is based on #159, not
main. Because the stacked base predates currentmain, #159 carries the exact already-merged #164 macOS process-identity fix so the full local Python suite is green; those four control-process files are not new review scope here.Central behavior
/v1/attentionpublishes complete counts plus a revision-bound, server-ranked queue. The additivesnapshotalias keeps the immediate predecessor desktop contract working.Real-state coverage
The reviewed matrix includes complete and partial queues, pagination overflow, revision drift, old daemons, statusless sessions, stale and retained errors, initial receipt loading, empty stores, malformed envelopes, sparse usage, extreme token/cost/reset values, and light/dark minimum/reference layouts. In these states the app never turns unavailable or incomplete evidence into All clear, No active work, a fabricated next step, a blank recorded fact, or a fabricated zero.
Review order
src/agentacct/api.py,tests/test_receipt_api.py, andV1Model.swift— attention revision, compatibility alias, ordering, and validation contract.DashboardStore.swift— request generations, cancellation/overlap ownership, retained-state policy, and fail-closed page publication.DashboardPane.swift,WorkPane.swift,SourcesPane.swift,UsageCapacity.swift,Theme.swift, andMenuPresentation.swift— user-visible truth, optional-context normalization, and numeric boundaries.Verification at current head
fbd6c69tests/test_receipt_api.py: 19 passed.DashboardInteractionTests: 49 passed, including blank/padded context and provenance coverage../Scripts/visual-snapshots verify DashboardVisualRegressionTests: all Dashboard references match the pinned canonical renderer.swift build -c release: passed.git diff --checkagainst Add truth-bounded dashboard decision signals #159: clean.Scope
This layer changes truth-state handling, server-ranked review paging, local navigation state, and boundary safety. Maximum accessibility-text reflow remains isolated in #161. No PR in this stack is merged by this change.